feat(math): add mutative api for Int.BigInt() #17803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
changed the title
|
Can we get tests + changelog (math/CHANGELOG.md) under unreleased feature? |
github-prbot
requested review from
a team,
tac0turtle and
julienrbrt
and removed request for
a team
julienrbrt
approved these changes
Sep 22, 2023
math/int_test.go
Outdated
| // Compare value of BigInt & BigIntMut | ||
| s.Require().Equal(i.BigInt(), i.BigIntMut()) | ||
|
|
||
| // Modify big.Int pointer and ensure i.BigIntMut change |
There was a problem hiding this comment.
For comparison, can we add the same when using BigInt and prove it ins't mutated?
|
Sr for delay, addressed. |
|
Can you merge main in your branch and we can merge. |
20 tasks
…smos-sdk into hieu/bigint_mut
auto-merge was automatically disabled
September 25, 2023 11:32
Head branch was pushed to by a user without write access
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #17772
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change