[CL Hooks]: Add hooks source and clean up source code folder #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlpinYukseloglu
added
V:state/compatible/no_backport
p0mvn
approved these changes
Nov 10, 2023
x/concentrated-liquidity/testcontracts/contract-sources/hooks/src/contract.rs
Outdated
Show resolved
Hide resolved
mattverse
approved these changes
Nov 13, 2023
|
|
||
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)] | ||
| pub struct State { | ||
| pub count: i64, |
There was a problem hiding this comment.
Is there a reason we keep a counter for this contract?
There was a problem hiding this comment.
This is unused in this case but will likely be important for #6862 so I had just left it there
| lower_tick: _, | ||
| upper_tick: _, | ||
| } => { | ||
| let mut response = Response::new(); |
There was a problem hiding this comment.
Seems that the following lines are duplicated regardless of which message (hook) it is, can we create a method for these lines?
AlpinYukseloglu
added
V:state/compatible/no_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds the source code used for testing in #6859. It also cleans up the testcontracts folder to be more approachable/readable.
This is done in a separate PR to avoid cluttering the base PR since the changes are light & state compatible but the diff is large