You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is important we ensure that the before hooks are actually executed before the after hooks in their respective function. While this is obviously correct in its current implementation, we should make sure that this is covered in tests so that future changes/additions to hook logic does not accidentally break this order.
Suggested Design
The current hook tests have a CW contract that sends 1 token with a denom corresponding to the hook trigger (e.g. beforeCreatePosition). One viable approach could be to either update this contract or make a second one where the number of tokens sent corresponds to the order the hooks were triggered.
Specifically, each hook trigger would increment a counter in state similar to in the counter test contract in x/concentrated-liquidity/testcontracts, and then assertions would be run on the specific number of tokens to ensure ordering is correct.
Acceptance Criteria
All new and existing tests pass
The text was updated successfully, but these errors were encountered:
Background
It is important we ensure that the
before
hooks are actually executed before theafter
hooks in their respective function. While this is obviously correct in its current implementation, we should make sure that this is covered in tests so that future changes/additions to hook logic does not accidentally break this order.Suggested Design
The current hook tests have a CW contract that sends 1 token with a denom corresponding to the hook trigger (e.g.
beforeCreatePosition
). One viable approach could be to either update this contract or make a second one where the number of tokens sent corresponds to the order the hooks were triggered.Specifically, each hook trigger would increment a counter in state similar to in the counter test contract in
x/concentrated-liquidity/testcontracts
, and then assertions would be run on the specific number of tokens to ensure ordering is correct.Acceptance Criteria
All new and existing tests pass
The text was updated successfully, but these errors were encountered: