Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS Incentives]: Remove liquidity-based reward splitting from CL #6142

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

AlpinYukseloglu
Copy link
Contributor

Closes: #6093

What is the purpose of the change

This PR removes liquidity-based reward splitting from CL. Please see the issue for the motivation and discussion surrounding this decision.

Testing and Verifying

Given how well-abstracted the original implementation was, this change was actually surprisingly simple.

It should be sufficient for all our existing CL incentives tests to pass.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn
Copy link
Member

p0mvn commented Aug 25, 2023

devbot fix

@p0mvn
Copy link
Member

p0mvn commented Aug 31, 2023

devbot merge base

# Conflicts:
#	x/concentrated-liquidity/incentives.go
#	x/concentrated-liquidity/incentives_test.go
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Aug 31, 2023
@p0mvn
Copy link
Member

p0mvn commented Aug 31, 2023

e2e failure is known flakiness: #6259

@p0mvn p0mvn merged commit c2790ce into main Aug 31, 2023
@p0mvn p0mvn deleted the alpo/remove-reward-splitting branch August 31, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VS Incentives]: Remove liquidity-based reward splitting from CL
3 participants