Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e twap flakiness #6259

Closed
p0mvn opened this issue Aug 31, 2023 · 3 comments
Closed

fix: e2e twap flakiness #6259

p0mvn opened this issue Aug 31, 2023 · 3 comments
Assignees
Labels
T:bug 🐛 Something isn't working

Comments

@p0mvn
Copy link
Member

p0mvn commented Aug 31, 2023

Background

e2e twap is flaky. needs fixing

https://github.com/osmosis-labs/osmosis/actions/runs/6041573925/attempts/3?pr=6256

Acceptance Criteria

  • fix
  • run 5 times to make sure fixed
@p0mvn
Copy link
Member Author

p0mvn commented Sep 1, 2023

Previously when we had a similar issue, this was the solution: #4359

Based on the review of twap history, there weren't any module changes that could break the above fix: https://github.com/osmosis-labs/osmosis/commits/main/x/twap

There were some instances that looked similar. A change was attempted but proved to be irrelevant: #6269

Next, proceeded to review CI history.

Taker fee #6034 was the first PR where I observed the failure.

I have 2 guesses:

  1. Taker fee in e2e is sometimes set before the e2e test (since tests are parallel). As a result, it non-deterministically breaks the twap tests. Attempted fix: fix(e2e): remove taker fee non-determinism affecting geo twap in e2e #6271
  2. Protorev in-parallel backruns the CL geo twap pool (haven't validated this, low-to-medium confidence on this

@p0mvn
Copy link
Member Author

p0mvn commented Sep 1, 2023

To be extra sure, attempting to remove the e2e taker fee changes: #6272

@p0mvn
Copy link
Member Author

p0mvn commented Sep 5, 2023

fixed

@p0mvn p0mvn closed this as completed Sep 5, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:bug 🐛 Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant