Make accumulator objects more consistently pointers throughout #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
V:state/compatible/backport
ValarDragon
commented
Jul 15, 2023
| @@ -426,14 +426,15 @@ func (accum AccumulatorObject) ClaimRewards(positionName string) (sdk.Coins, sdk | |||
|
|
|||
| // GetTotalShares returns the total number of shares in the accumulator | |||
| func (accum AccumulatorObject) GetTotalShares() (sdk.Dec, error) { | |||
| accum, err := GetAccumulator(accum.store, accum.name) | |||
| return accum.totalShares, err | |||
| // TODO: Make this not do an extra get. | |||
There was a problem hiding this comment.
This TODO is the only new line introduced by this PR :)
p0mvn
approved these changes
Jul 17, 2023
|
Yes, one is in #5849 ! |
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
* Make accumulator objects more consistently pointers throughout * Update go mod (cherry picked from commit 04596ca) # Conflicts: # go.mod # go.sum
ValarDragon
added a commit
that referenced
this pull request
Jul 28, 2023
…ort #5848) (#5865) * Make accumulator objects more consistently pointers throughout (#5848) * Make accumulator objects more consistently pointers throughout * Update go mod (cherry picked from commit 04596ca) # Conflicts: # go.mod # go.sum * fix imports --------- Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Dev Ojha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component of #5845
State compatible component of removing some unneeded store re-gets!
After this, we should be able to then remove some unneeded re-gets for accumulators :)
No new tests, safety of this should be covered by existing tests + resyncing on mainnet.