You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the accumulator package, we do repeated gets in several locations. This is because we are not using pointers for the base of functions, so mutations are not getting tracked correctly.
Changing status back to "In Progress" from "Done" since it appears the PR linked was only a component. Are you able to list out further components so we can get these knocked out?
In the accumulator package, we do repeated gets in several locations. This is because we are not using pointers for the base of functions, so mutations are not getting tracked correctly.
We should make GetAccumulator return a pointer, and then we can save redundant state operations, such as right here: https://github.com/osmosis-labs/osmosis/blob/main/osmoutils/accum/accum.go#L151-L155
This should with execution time and gas costs.
The text was updated successfully, but these errors were encountered: