Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: zero for one tick crossing bug for swap in given out #5591

Merged
merged 3 commits into from
Jun 21, 2023
Merged

fix: zero for one tick crossing bug for swap in given out #5591

merged 3 commits into from
Jun 21, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jun 20, 2023

Progress towards: #5573

What is the purpose of the change

Applying the same fix for swap in given out as was done in #5526

Testing and Verifying

The cross tick test suite is to be expanded to cover swap in given out in a future PR

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added V:state/breaking State machine breaking PR A:no-changelog labels Jun 20, 2023
@p0mvn p0mvn marked this pull request as ready for review June 20, 2023 20:59
@p0mvn p0mvn requested a review from czarcas7ic as a code owner June 20, 2023 20:59
czarcas7ic
czarcas7ic approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks

@p0mvn
Copy link
Member Author

p0mvn commented Jun 21, 2023

Resolved conflicts. Planning to merge once CI passes

@p0mvn p0mvn merged commit e004a3d into main Jun 21, 2023
@p0mvn p0mvn deleted the roman/fix-swap-in-given-out-tick-cross branch June 21, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

Assignees
No one assigned
Labels
A:no-changelog C:x/concentrated-liquidity V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @czarcas7ic