Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/fix/test(CL): tick crossing for swap in given out #5573

Closed
p0mvn opened this issue Jun 19, 2023 · 0 comments
Closed

refactor/fix/test(CL): tick crossing for swap in given out #5573

p0mvn opened this issue Jun 19, 2023 · 0 comments
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Jun 19, 2023

Background

#5526 and #5567 changed the invariants of crossing a tick and added tests

Suggested Design

We now need to update and test swap in given out

Acceptance Criteria

  • swap in given out is updated to mirror changes in the linked PRs for swap out given in
  • strict tick crossing tests added
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jun 19, 2023
@p0mvn p0mvn self-assigned this Jun 19, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Jun 19, 2023
This was referenced Jun 20, 2023
Merged
Merged
@p0mvn p0mvn moved this from Needs Triage 🔍 to In Progress🏃 in Osmosis Chain Development Jun 26, 2023
@p0mvn p0mvn closed this as completed Aug 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p0mvn