Protorev query highest liquidity pools (backport #4829) #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Update proto files for protorev pool query - protorev pool query will return pool id given a denom pair for the highest liquidity method * add grpc query handler logic for GetProtoRevPool query * Add cli query support * Add test for GetProtoRevPool query * Change endpoint to pool and re-gen proto code * add pool query in documentation * Specify the query is for highest liquidity method pools only * Change comment to represent query Co-authored-by: David Terpay <[email protected]> * change comments in proto file and generated pb * fix test comment * Add query to changelog --------- Co-authored-by: David Terpay <[email protected]> (cherry picked from commit 5f4beb7) # Conflicts: # CHANGELOG.md # x/protorev/client/cli/query.go # x/protorev/protorev.md
github-actions
bot
added
C:CLI
C:docs
|
Hi @NotJeremyLiu , can you please help with resolvng conflicts? |
- Main issue I think is I rebased on main when I should've rebased on v15 since this was to be backported - I only added this entry into the changelog since the other changes may not be reflected in the backport
|
@p0mvn resolved conflicts, should be good to merge now |
p0mvn
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4829 done by Mergify.
Cherry-pick of 5f4beb7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com