Protorev query highest liquidity pools #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotJeremyLiu
added
the
V:state/compatible/backport
|
Added label for non-state breaking, don't know if it should be backport or no-backport |
Closed
davidterpay
reviewed
Apr 10, 2023
davidterpay
reviewed
Apr 10, 2023
x/protorev/client/cli/query.go
Outdated
| func NewQueryPoolCmd() (*osmocli.QueryDescriptor, *types.QueryGetProtoRevPoolRequest) { | ||
| return &osmocli.QueryDescriptor{ | ||
| Use: "pool [base_denom] [other_denom]", | ||
| Short: "Query the pool id for a given denom pair stored in ProtoRev", |
There was a problem hiding this comment.
Update this based on the comment above.
There was a problem hiding this comment.
yeah, just want highest liquidity pools. Specified here: 821b247
2 tasks
|
Let's add a changelog entry for this and merge |
- protorev pool query will return pool id given a denom pair for the highest liquidity method
Co-authored-by: David Terpay <[email protected]>
NotJeremyLiu
force-pushed
the
jl/protorev-query-highest-liq-pools
branch
from
8838a65 to
7049f01
Compare
Added in: 7049f01 and rebased on main, so should be ready to merge. |
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
* Update proto files for protorev pool query - protorev pool query will return pool id given a denom pair for the highest liquidity method * add grpc query handler logic for GetProtoRevPool query * Add cli query support * Add test for GetProtoRevPool query * Change endpoint to pool and re-gen proto code * add pool query in documentation * Specify the query is for highest liquidity method pools only * Change comment to represent query Co-authored-by: David Terpay <[email protected]> * change comments in proto file and generated pb * fix test comment * Add query to changelog --------- Co-authored-by: David Terpay <[email protected]> (cherry picked from commit 5f4beb7) # Conflicts: # CHANGELOG.md # x/protorev/client/cli/query.go # x/protorev/protorev.md
p0mvn
pushed a commit
that referenced
this pull request
Apr 19, 2023
* Protorev query highest liquidity pools (#4829) * Update proto files for protorev pool query - protorev pool query will return pool id given a denom pair for the highest liquidity method * add grpc query handler logic for GetProtoRevPool query * Add cli query support * Add test for GetProtoRevPool query * Change endpoint to pool and re-gen proto code * add pool query in documentation * Specify the query is for highest liquidity method pools only * Change comment to represent query Co-authored-by: David Terpay <[email protected]> * change comments in proto file and generated pb * fix test comment * Add query to changelog --------- Co-authored-by: David Terpay <[email protected]> (cherry picked from commit 5f4beb7) # Conflicts: # CHANGELOG.md # x/protorev/client/cli/query.go # x/protorev/protorev.md * Resolve merge conflicts - Main issue I think is I rebased on main when I should've rebased on v15 since this was to be backported - I only added this entry into the changelog since the other changes may not be reflected in the backport --------- Co-authored-by: Jeremy Liu <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief Changelog
Testing and Verifying
Documentation and Release Note