Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate denom-authority-metadata query command #4819

Merged
merged 9 commits into from
May 30, 2023
Merged

Remove duplicate denom-authority-metadata query command #4819

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
726a8ff
remove duplicate denom-authority-metadata query command
phamminh0811 Apr 3, 2023
c6c7fda
Merge branch 'main' into minh/remove-duplicate-query
phamminh0811 Apr 3, 2023
7760872
merge main
phamminh0811 Apr 3, 2023
92d23cb
revert change
phamminh0811 Apr 4, 2023
2223454
revert change
phamminh0811 Apr 4, 2023
94c1204
fix lint
phamminh0811 Apr 4, 2023
3b7010f
Merge branch 'main' into minh/remove-duplicate-query
phamminh0811 Apr 27, 2023
6d97d64
add GetCmdDenomsFromCreator and CHANGELOG
phamminh0811 Apr 27, 2023
4773420
Merge branch 'main' into minh/remove-duplicate-query
faddat May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ This release containts the following new modules:
* [#4388](https://github.com/osmosis-labs/osmosis/pull/4388) Increase the max allowed contract size for non-proposal contracts to 3MB
* [#4384](https://github.com/osmosis-labs/osmosis/pull/4384) migrate stXXX/XXX constant product pools 833, 817, 810 to stable swap
* [#4461](https://github.com/osmosis-labs/osmosis/pull/4461) added rate limit quotas for a set of high value tokens
* [#4819](https://github.com/osmosis-labs/osmosis/pull/4819) remove duplicate denom-authority-metadata query command

### API breaks

Expand Down
2 changes: 1 addition & 1 deletion x/tokenfactory/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func GetQueryCmd() *cobra.Command {
cmd := osmocli.QueryIndexCmd(types.ModuleName)

osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetCmdDenomAuthorityMetadata)
osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetCmdDenomAuthorityMetadata)
osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetCmdDenomsFromCreator)
Comment on lines 22 to +23
Copy link
Member

@czarcas7ic czarcas7ic May 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phamminh0811 can you please do two things:

  1. Add the GetCmdDenomBeforeSendHook query here as well
  2. Test them locally on mainnet and ack that they behave as expected

As soon as thats done, please ping me and I will merge :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please check


phamminh0811 marked this conversation as resolved.
Show resolved Hide resolved
cmd.AddCommand(
osmocli.GetParams[*types.QueryParamsRequest](
Expand Down