Remove duplicate denom-authority-metadata query command #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamminh0811
added
the
V:state/compatible/no_backport
pysel
approved these changes
Apr 4, 2023
phamminh0811
added
V:state/compatible/backport
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
How about change the command handler to |
czarcas7ic
reviewed
May 7, 2023
Comment on lines
22
to
+23
| osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetCmdDenomAuthorityMetadata) | ||
| osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetCmdDenomAuthorityMetadata) | ||
| osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetCmdDenomsFromCreator) |
There was a problem hiding this comment.
@phamminh0811 can you please do two things:
- Add the GetCmdDenomBeforeSendHook query here as well
- Test them locally on mainnet and ack that they behave as expected
As soon as thats done, please ping me and I will merge :)
There was a problem hiding this comment.
Done, please check
|
@phamminh0811 any update on this? |
|
@phamminh0811 @pysel any updates here? |
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2023
* remove duplicate denom-authority-metadata query command * merge main * revert change * revert change * fix lint * add GetCmdDenomsFromCreator and CHANGELOG --------- Co-authored-by: Jacob Gadikian <[email protected]> (cherry picked from commit 50b26a8) # Conflicts: # CHANGELOG.md
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* remove duplicate denom-authority-metadata query command * merge main * revert change * revert change * fix lint * add GetCmdDenomsFromCreator and CHANGELOG --------- Co-authored-by: Jacob Gadikian <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4784
Brief Changelog
Remove duplicate "denom-authority-metadata" query command