refactor[CL]: remove freezeDuration as a parameter #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c1bc13.
czarcas7ic
added
C:docs
czarcas7ic
changed the title
czarcas7ic
commented
Mar 25, 2023
| @@ -101,7 +101,7 @@ func (n *NodeConfig) StoreWasmCode(wasmFile, from string) { | |||
|
|
|||
| func (n *NodeConfig) WithdrawPosition(from, liquidityOut string, positionId uint64) { | |||
| n.LogActionF("withdrawing liquidity from position") | |||
| cmd := []string{"osmosisd", "tx", "concentratedliquidity", "withdraw-position", fmt.Sprint(positionId), liquidityOut, fmt.Sprintf("--from=%s", from)} | |||
| cmd := []string{"osmosisd", "tx", "concentratedliquidity", "withdraw-position", fmt.Sprint(positionId), liquidityOut, fmt.Sprintf("--from=%s", from), "--gas=auto", "--gas-prices=0.1uosmo", "--gas-adjustment=1.3"} | |||
There was a problem hiding this comment.
TODO: Make an issue regarding this gas adjustment that had to be made for this transaction to go through
czarcas7ic
commented
Mar 26, 2023
Comment on lines
48
to
49
| "/osmosis/poolmanager/v1beta1/{pool_id}/estimate_out/" | ||
| "single_pool_swap_exact_amount_out"; |
There was a problem hiding this comment.
Checked this, apparently it happens automatically from the proto linter, weird.
p0mvn
reviewed
Mar 27, 2023
czarcas7ic
commented
Mar 28, 2023
p0mvn
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4651
What is the purpose of the change
We no longer need the freezeDuration parameter, as we are now utilizing accumulators for all positions, and simply force users to forfeit accumulated rewards if they leave prior to the rewards minimum uptime charging period.
This PR removes the parameter and refactors various tests to achieve this.
Most notably, we no longer determine forfeiting incentives as binary, and rather iterate a position ID over the various rewards accumulators to determine if the position has existed long enough to claim its share of the rewards, or forfeit them due to not being in the position long enough.
Brief Changelog
Testing and Verifying
This PR refactors existing tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)