Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL]: Investigate gas consumption for withdraw #4774

Closed
czarcas7ic opened this issue Mar 28, 2023 · 0 comments · Fixed by #5012
Closed

[CL]: Investigate gas consumption for withdraw #4774

czarcas7ic opened this issue Mar 28, 2023 · 0 comments · Fixed by #5012
Assignees
@czarcas7ic
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@czarcas7ic
Copy link
Member

Background

We no longer utilize freezeDuration. Therefore, when a user withdraws a single position, we need to iterate over all authorized durations to determine which incentivized durations the user is forfeiting and which they claim. When this was added, I had to increase the gas in e2e (I think it used somewhere around 500000). See https://github.com/osmosis-labs/osmosis/pull/4724/files#r1148431159

Suggested Design

We need to set up a testing environment to determine what the max value this gas consumption can be. It would also be good to point a finger at specifically what is causing this larger than usual gas value and potentially refactor.

Acceptance Criteria

  • Max gas consumed is determined
  • If possible, refactor to reduce gas costs
@czarcas7ic czarcas7ic added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Mar 28, 2023
@czarcas7ic czarcas7ic mentioned this issue Mar 28, 2023
Merged
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Mar 28, 2023
@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Apr 24, 2023
@czarcas7ic czarcas7ic moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Apr 26, 2023
@czarcas7ic czarcas7ic mentioned this issue Apr 26, 2023
Merged
@czarcas7ic czarcas7ic moved this from In Progress🏃 to Needs PR Review in Osmosis Chain Development Apr 26, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czarcas7ic czarcas7ic

Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests[CL]: change withdraw gas from auto in e2e osmosis-labs/osmosis
1 participant
@czarcas7ic