[e2e][CL]: pool migration

[ThanhNhann]

Closes: #4496

What is the purpose of the change

Add e2e test pool migrations from balancer/stableswap to CL

Brief Changelog

• Add e2e test pool migrations from balancer/stableswap to CL with 3 steps:
  • Submit a gov proposal to update pools allowed to migrate
  • Migrate your position from balancer / stableswap to CL
  • Validate that the position migrated correctly

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added unit test that validates ...
• Added integration tests for end-to-end deployment with ...
• Extended integration test for ...
• Manually verified the change by ...

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
• Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
• How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

[github-actions]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

[czarcas7ic]

@ThanhNhann just wanted to check in to see what the plan for this was

[ThanhNhann]

Hi @czarcas7ic, thanks for your ping, I'm updating it

[ThanhNhann]

yeah, I will update the code with @mattverse review today @czarcas7ic, just missing the notifications of this pr, so sorry for this

[czarcas7ic]

@ThanhNhann please ping when r4r, thanks!

[ThanhNhann]

It's good to review now @czarcas7ic

[mattverse]

LGTM, I have left some last comments that would be best if addressed, after that I think we should be good for merge

[czarcas7ic]

@ThanhNhann would like the point about 6 cases vs 4 addressed, then I think we are good to merge.

[ThanhNhann]

thanks your review @czarcas7ic, I will update soon

[czarcas7ic]

Nice work on this! I want to do one more review before merging though

[czarcas7ic]

Why do we use safesub here? there should never be a time when this value is negative

[ThanhNhann]

balanceAfterJoin will have another coin after joining pool so I think we should use SafeSub here

[czarcas7ic]

Hey, sorry for tall the back and forths on this. It looks like this test is significantly longer when compared to all the other E2E tests:

    --- PASS: TestIntegrationTestSuite/TestAConcentratedLiquidity_CanonicalPool_And_Parameters (0.46s)
    --- PASS: TestIntegrationTestSuite/TestAddToExistingLock (39.69s)
    --- PASS: TestIntegrationTestSuite/TestAddToExistingLockPostUpgrade (2.63s)
    --- SKIP: TestIntegrationTestSuite/TestArithmeticTWAP (0.00s)
    --- PASS: TestIntegrationTestSuite/TestConcentratedLiquidity (93.36s)
    --- PASS: TestIntegrationTestSuite/TestCreateConcentratedLiquidityPoolVoting_And_TWAP (42.77s)
    --- PASS: TestIntegrationTestSuite/TestExpeditedProposals (21.58s)
    --- PASS: TestIntegrationTestSuite/TestGeometricTWAP (12.51s)
    --- PASS: TestIntegrationTestSuite/TestGeometricTwapMigration (4.51s)
    --- PASS: TestIntegrationTestSuite/TestIBCTokenTransferAndCreatePool (60.43s)
    --- PASS: TestIntegrationTestSuite/TestIBCTokenTransferRateLimiting (61.23s)
    --- PASS: TestIntegrationTestSuite/TestIBCWasmHooks (8.40s)
    --- PASS: TestIntegrationTestSuite/TestLargeWasmUpload (4.03s)
    --- PASS: TestIntegrationTestSuite/TestPacketForwarding (10.96s)
    --- PASS: TestIntegrationTestSuite/TestPoolMigration (483.99s)
    --- PASS: TestIntegrationTestSuite/TestProtoRev (45.92s)
    --- PASS: TestIntegrationTestSuite/TestStableSwapPostUpgrade (6.62s)
    --- PASS: TestIntegrationTestSuite/TestStateSync (52.40s)
    --- PASS: TestIntegrationTestSuite/TestSuperfluidVoting (39.96s)

We might need to add some randomized logic to select a single migration path rather than checking every one every time. That or add some go routines in the test itself. 100s I think should be the max for one of these tests, and this is almost 5x that (not at all your fault, its a hefty test, just need to make this shorter)

[github-actions]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!