Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e][CL]: pool migration #4496

Closed
p0mvn opened this issue Mar 3, 2023 · 2 comments
Closed

[e2e][CL]: pool migration #4496

p0mvn opened this issue Mar 3, 2023 · 2 comments
Assignees
@ThanhNhann
Labels
C:e2e F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board Help wanted

Comments

@p0mvn
Copy link
Member

p0mvn commented Mar 3, 2023

Background

We need to e2e test pool migrations from balancer/stableswap to CL

Suggested Design

The test should work as follows:

  1. Submit a gov proposal to update pools allowed to migrate (ref: https://github.com/osmosis-labs/osmosis/pull/4451/files#diff-74d38952fd4b8e2c78fda8dc9e55541e08d40692b9425cd5deed815482efa83dR10-R27)

  2. Migrate your position from balancer / stableswap to CL

  3. Validate that the position migrated correctly

  • full range
  • approximately the same value

Acceptance Criteria

  • the test is added as per the suggested design
  • passes
@p0mvn p0mvn added C:e2e F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board Help wanted labels Mar 3, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Mar 3, 2023
@ThanhNhann ThanhNhann self-assigned this Mar 6, 2023
@ThanhNhann ThanhNhann mentioned this issue Mar 21, 2023
Closed
@p0mvn p0mvn moved this from Needs Triage 🔍 to Needs PR Review in Osmosis Chain Development Mar 26, 2023
@ThanhNhann ThanhNhann mentioned this issue Mar 27, 2023
Merged
@p0mvn
Copy link
Member Author

p0mvn commented Apr 10, 2023

This issue depends on: #4855

@p0mvn p0mvn moved this from Needs PR Review to Needs Triage 🔍 in Osmosis Chain Development Apr 26, 2023
@ThanhNhann
Copy link
Contributor

This issue depends on: #4906

@p0mvn p0mvn moved this from Needs Triage 🔍 to On Hold in Osmosis Chain Development May 23, 2023
@czarcas7ic czarcas7ic moved this from On Hold to Todo 🕒 in Osmosis Chain Development May 30, 2023
@p0mvn p0mvn closed this as completed Aug 8, 2023
@github-project-automation github-project-automation bot moved this from Todo 🕒 to Done ✅ in Osmosis Chain Development Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThanhNhann ThanhNhann

Labels
C:e2e F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board Help wanted
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[e2e][CL]: pool migration osmosis-labs/osmosis
2 participants
@ThanhNhann @p0mvn