test(e2e): upgrade e2e init image for Stride migration #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
stackman27
reviewed
Feb 22, 2023
| @@ -1121,10 +1121,6 @@ func (s *IntegrationTestSuite) TestGeometricTWAP() { | |||
| // This test is to be re-enabled for upgrade once the upgrade handler logic is added and | |||
| // the balancer pool genesis is backported to v14. | |||
| func (s *IntegrationTestSuite) TestStridePoolMigration() { | |||
| if !s.skipUpgrade { | |||
There was a problem hiding this comment.
Why did we remove this logic again?
There was a problem hiding this comment.
We disabled this previously because the v14 genesis was not updated. As a result, this test would fail when run with upgrade testing enabled.
Now, that we updated the v14 genesis generation via the osmolabs/osmosis-e2e-init-chain script, this test can be enabled with the upgrade
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* test(e2e): upgrade e2e init image for Stride migration * update tag (cherry picked from commit 00a264b)
p0mvn
added a commit
that referenced
this pull request
Feb 22, 2023
* test(e2e): upgrade e2e init image for Stride migration * update tag (cherry picked from commit 00a264b) Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Updating previous (V14) e2e chain init Docker image to apply genesis changes from #4393 needed for #4384