Setup e2e test for Stride pool migration #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
p0mvn
commented
Feb 22, 2023
| @@ -31,9 +30,6 @@ func FormatModuleRouteKey(poolId uint64) []byte { | |||
| // ParseModuleRouteFromBz parses the raw bytes into ModuleRoute. | |||
| // Returns error if fails to parse or if the bytes are empty. | |||
| func ParseModuleRouteFromBz(bz []byte) (ModuleRoute, error) { | |||
| if len(bz) == 0 { | |||
There was a problem hiding this comment.
Note: bz of length zero is expected because when we serialize ModuleRoute that has PoolType Balancer that is equal to zero, the serialization ends up being empty bytes.
p0mvn
force-pushed
the
roman/stride-migration-e2e
branch
from
6bdecc7 to
48418b3
Compare
stackman27
approved these changes
Feb 22, 2023
stackman27
reviewed
Feb 22, 2023
Co-authored-by: Sishir Giri <[email protected]>
Co-authored-by: Sishir Giri <[email protected]>
Co-authored-by: Sishir Giri <[email protected]>
p0mvn
added
V:state/breaking
|
Marked this as state-breaking since modified some state entries in the new Also, would like to give this another round of eyes before v15 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Setup e2e test for Stride pool migratio * add pool shares to balances of pool addresses in e2e genesis * remove debugging log * Update x/poolmanager/create_pool.go Co-authored-by: Sishir Giri <[email protected]> * Update proto/osmosis/poolmanager/v1beta1/genesis.proto Co-authored-by: Sishir Giri <[email protected]> * Update tests/e2e/initialization/config.go Co-authored-by: Sishir Giri <[email protected]> * proto --------- Co-authored-by: Sishir Giri <[email protected]> (cherry picked from commit b3cd00c) # Conflicts: # proto/osmosis/poolmanager/v1beta1/genesis.proto # proto/osmosis/poolmanager/v1beta1/module_route.proto # tests/e2e/initialization/config.go # x/poolmanager/create_pool.go # x/poolmanager/create_pool_test.go # x/poolmanager/export_test.go # x/poolmanager/keeper.go # x/poolmanager/keeper_test.go # x/poolmanager/types/genesis.pb.go # x/poolmanager/types/keys.go # x/poolmanager/types/module_route.pb.go
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Setup e2e test for Stride pool migratio * add pool shares to balances of pool addresses in e2e genesis * remove debugging log * Update x/poolmanager/create_pool.go Co-authored-by: Sishir Giri <[email protected]> * Update proto/osmosis/poolmanager/v1beta1/genesis.proto Co-authored-by: Sishir Giri <[email protected]> * Update tests/e2e/initialization/config.go Co-authored-by: Sishir Giri <[email protected]> * proto --------- Co-authored-by: Sishir Giri <[email protected]> (cherry picked from commit b3cd00c) # Conflicts: # x/poolmanager/types/module_route.pb.go
This was referenced Feb 22, 2023
p0mvn
added a commit
that referenced
this pull request
Feb 22, 2023
p0mvn
added a commit
that referenced
this pull request
Feb 22, 2023
p0mvn
added a commit
that referenced
this pull request
Feb 22, 2023
Co-authored-by: Roman <[email protected]>
p0mvn
added a commit
that referenced
this pull request
Feb 22, 2023
Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This PR sets up e2e for Stride's pool migration in #4384
It does so by modifying genesis to create all pools up until and including the last pool id of the Stride's osmo - stOsmo pool.
It then adds a swap test to make sure that we can continue swapping after running the upgrade handler with migrations.
The test is currently disabled as we need to backport this genesis change to v14 and update the chain init image here: https://hub.docker.com/r/osmolabs/osmosis-e2e-init-chain
However, this has been successfully tested via current branch e2e test.
Brief Changelog
poolmanagergenesis to contain the mapping from pool id to pool type