Integrate Async ICQ #4207
+78
−13
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,8 @@ require ( | |
| github.com/spf13/cobra v1.6.1 | ||
| github.com/spf13/pflag v1.0.5 | ||
| github.com/spf13/viper v1.15.0 | ||
| // Async ICQ branch: ibc-v4 | ||
| github.com/strangelove-ventures/async-icq v0.0.0-20230116084035-5609e84dd443 | ||
|
There was a problem hiding this comment. LGTM, can we add a release blocking TODO / issue for this to be replaced with a tag? There was a problem hiding this comment. Added #4218. I'll ping them to add a tag There was a problem hiding this comment. also, how do I make a ticket release blocking? There was a problem hiding this comment. We can add it to the tracker issue for now |
||
| github.com/stretchr/testify v1.8.1 | ||
| github.com/tendermint/tendermint v0.34.24 | ||
| github.com/tendermint/tm-db v0.6.8-0.20220506192307-f628bb5dc95b | ||
|
|
@@ -67,7 +69,7 @@ require ( | |
|
|
||
| require ( | ||
| 4d63.com/gochecknoglobals v0.1.0 // indirect | ||
| filippo.io/edwards25519 v1.0.0-rc.1 // indirect | ||
| github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect | ||
| github.com/99designs/keyring v1.2.1 // indirect | ||
| github.com/Antonboom/errname v0.1.7 // indirect | ||
|
|
@@ -83,7 +85,7 @@ require ( | |
| github.com/OpenPeeDeeP/depguard v1.1.1 // indirect | ||
| github.com/Workiva/go-datastructures v1.0.53 // indirect | ||
| github.com/alexkohler/prealloc v1.0.0 // indirect | ||
| github.com/armon/go-metrics v0.4.1 // indirect | ||
| github.com/ashanbrown/forbidigo v1.3.0 // indirect | ||
| github.com/ashanbrown/makezero v1.1.1 // indirect | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
|
|
@@ -174,9 +176,9 @@ require ( | |
| github.com/hashicorp/go-immutable-radix v1.3.1 // indirect | ||
| github.com/hashicorp/go-multierror v1.1.1 // indirect | ||
| github.com/hashicorp/go-version v1.6.0 // indirect | ||
| github.com/hashicorp/golang-lru v0.5.5-0.20210104140557-80c98217689d // indirect | ||
| github.com/hashicorp/hcl v1.0.0 // indirect | ||
| github.com/hdevalence/ed25519consensus v0.0.0-20220222234857-c00d1f31bab3 // indirect | ||
| github.com/hexops/gotextdiff v1.0.3 // indirect | ||
| github.com/imdario/mergo v0.3.13 // indirect | ||
| github.com/improbable-eng/grpc-web v0.15.0 // indirect | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment for what these args are supposed to be? (Confused why theres two)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing it twice is common on IBC modules where you want one with the default implementation and one that is being used to actually route packages through (if there's a middleware, you want to route packets through the middleware but may still need access to the default IBC implementation).
In this case, I don't think the second one is being used. So not sure why it's needed. And the first one is only being used to return the correct app version when implementing
GetAppVersion(which is required by the interface)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, I imagine this API / standard could be improved, but for another day (and potentially requires IBC changes). SGTM!