Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Async ICQ dependency with a tag #4218

Closed
Tracked by #4170
nicolaslara opened this issue Feb 3, 2023 · 0 comments · Fixed by #4276
Closed
Tracked by #4170

Replace Async ICQ dependency with a tag #4218

nicolaslara opened this issue Feb 3, 2023 · 0 comments · Fixed by #4276
Assignees
@nicolaslara

Comments

@nicolaslara
Copy link
Contributor

Background

Ref: #4207 (comment)

Async ICQ (https://github.com/strangelove-ventures/async-icq) doesn't currently have tags for releases (particularly the one we need which is the SDK 0.45 + IBCv4).

Suggested Design

Replace the commit specified in go.mod for the tag

Acceptance Criteria

Release is using the tag. All tests pass
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Feb 3, 2023
This was referenced Feb 3, 2023
Merged
Closed
Merged
@nicolaslara nicolaslara moved this from Needs Review 🔍 to Needs PR Review in Osmosis Chain Development Feb 10, 2023
@nicolaslara nicolaslara self-assigned this Feb 10, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaslara nicolaslara

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tagged async-icq osmosis-labs/osmosis
1 participant
@nicolaslara