[CL]: Deprecate duplicated queries from gamm module #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
mattverse
added
the
V:state/compatible/no_backport
mattverse
changed the title
p0mvn
reviewed
Jan 3, 2023
Co-authored-by: Roman <[email protected]>
p0mvn
reviewed
Jan 5, 2023
Comment on lines
15
to
16
| lockuptypes "github.com/osmosis-labs/osmosis/v13/x/lockup/types" | ||
| swaprouterqueryproto "github.com/osmosis-labs/osmosis/v13/x/swaprouter/client/queryproto" |
There was a problem hiding this comment.
Suggested change
| lockuptypes "github.com/osmosis-labs/osmosis/v13/x/lockup/types" | |
| swaprouterqueryproto "github.com/osmosis-labs/osmosis/v13/x/swaprouter/client/queryproto" | |
| gammtypes "github.com/osmosis-labs/osmosis/v13/x/gamm/types" | |
| lockuptypes "github.com/osmosis-labs/osmosis/v13/x/lockup/types" |
czarcas7ic
approved these changes
Jan 5, 2023
czarcas7ic
reviewed
Jan 5, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3883
What is the purpose of the change
This PR deprecates three of the following queries from the gamm module since they have been moved to the swap rotuer module.
Protos remained undeleted but marked deprecated using the deprecation option in proto3.
This PR also removes the three queries from the stargate whitelist list.
Brief Changelog
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yesx/<module>/spec/) / Osmosis docs repo / not documented)