Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/gamm): mark queries deprecated #3883

Closed
p0mvn opened this issue Dec 29, 2022 · 0 comments · Fixed by #3905
Closed

refactor(x/gamm): mark queries deprecated #3883

p0mvn opened this issue Dec 29, 2022 · 0 comments · Fixed by #3905
Assignees
@mattverse
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Milestone
CL7: Swap Router ...

Comments

@p0mvn
Copy link
Member

p0mvn commented Dec 29, 2022

Background

We mvoed some of the queries from x/gamm to x/swaprouter

All relevant queries are listed here:
#3882

Suggested Design

For each of the query and a related proto-struct, update x/gamm proto file to add the following comment above the struct's proto definition:

// Deprecated: please use the alternative in x/swaprouter

Regenerate the proto files. Resolve linter.

Acceptance Criteria

  • deprecation comments added
  • proto regenerated
  • linter resolved
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Dec 29, 2022
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Dec 29, 2022
@mattverse mattverse mentioned this issue Jan 3, 2023
Merged
@mattverse mattverse self-assigned this Jan 3, 2023
@github-project-automation github-project-automation bot moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
CL7: Swap Router V14 QA and Tweaks
Development

Successfully merging a pull request may close this issue.

[CL]: Deprecate duplicated queries from gamm module osmosis-labs/osmosis
2 participants
@p0mvn @mattverse