refactor(osmomath): replace Power with PowerInteger #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM, but it should be state compatible and backportable? |
Agreed. Sorry I confused it with this Line 57 in d69dd69 |
p0mvn
added
V:state/compatible/backport
|
Labels are now changed |
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
* refactor(osmomath): replace Power with PowerInteger * changelog * changelog 2 (cherry picked from commit 5df8cd0) # Conflicts: # CHANGELOG.md
p0mvn
added a commit
that referenced
this pull request
Dec 14, 2022
p0mvn
added a commit
that referenced
this pull request
Dec 14, 2022
…3727) * refactor(osmomath): replace Power with PowerInteger (backport #3712) * Update CHANGELOG.md Co-authored-by: Roman <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards: #3540
What is the purpose of the change
I missed the existence of
Powerwhen addingPowerInteger. As a result, these functions are identical.I propose removing the old
Powerand replace all calls withPowerIntegersince I am adding a newPowerfunction that takes a decimal exponent.Note:
Poweris identical withPowerIntegerPowerIntegertests include and cover all removed test cases.