Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(twap): add overflow tests for geometric TWAP #3540

Closed
p0mvn opened this issue Nov 27, 2022 · 0 comments · Fixed by #3809
Closed

test(twap): add overflow tests for geometric TWAP #3540

p0mvn opened this issue Nov 27, 2022 · 0 comments · Fixed by #3809
Assignees
@p0mvn
Labels
F: geometric-twap T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented Nov 27, 2022

Background

Geometric TWAP needs overflow tests here

Suggested Design

Add potentially overflowing tests with:

  • max spot price
  • large time delta
    • 2 days
    • 100 days
  • both

If math functions panic, identify and document the maximum values at which the tests do not panic.

Acceptance Criteria

  • requested tests added
  • if panics, occur find the maximum values that do not and create a follow-up issue to investigate
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Nov 27, 2022
This was referenced Nov 27, 2022
Closed
Merged
@p0mvn p0mvn self-assigned this Dec 1, 2022
This was referenced Dec 14, 2022
Merged
Merged
Merged
Closed
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: geometric-twap T:tests
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(x/twap): use exp2 in twapPow; add overflow test osmosis-labs/osmosis
1 participant
@p0mvn