refactor(osmoutils): use Dec for additive tolerance instead of Int #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/no_backport
github-actions
bot
added
the
C:x/gamm
p0mvn
requested review from
ValarDragon,
AlpinYukseloglu,
czarcas7ic,
nicolaslara and
stackman27
and removed request for
AlpinYukseloglu
nicolaslara
approved these changes
Dec 14, 2022
czarcas7ic
approved these changes
Dec 14, 2022
|
Needs to be backported to work w/ v13.x having osmomath in its own go.mod |
ValarDragon
added
V:state/compatible/backport
mergify bot
pushed a commit
that referenced
this pull request
Dec 21, 2022
…3711) * refactor(osmoutils): use Dec for additive tolerance instead of Int * changelog (cherry picked from commit 5ab7ebf) # Conflicts: # CHANGELOG.md # osmomath/binary_search.go # x/gamm/pool-models/balancer/pool_test.go # x/gamm/pool-models/internal/cfmm_common/lp.go # x/gamm/pool-models/stableswap/amm.go # x/gamm/pool-models/stableswap/amm_test.go
ValarDragon
pushed a commit
that referenced
this pull request
Dec 21, 2022
…3711) * refactor(osmoutils): use Dec for additive tolerance instead of Int * changelog (cherry picked from commit 5ab7ebf) # Conflicts: # CHANGELOG.md # osmomath/binary_search.go # x/gamm/pool-models/balancer/pool_test.go # x/gamm/pool-models/internal/cfmm_common/lp.go # x/gamm/pool-models/stableswap/amm.go # x/gamm/pool-models/stableswap/amm_test.go
ValarDragon
added a commit
that referenced
this pull request
Dec 21, 2022
* Move osmomath into its own go.mod (#3771) * Move osmomath into its own go.mod * Fix go mods * fix osmomath test build * Tryfix e2e test * Try removing osmomath from the copy line? * Add osmomath to first copy * Try another layer * Make build work off of tagged releases * Switch prod and E2E builds to ignore go work * Fix merge conflict * Add root dir to go work * Fix conflict (cherry picked from commit 079702e) # Conflicts: # go.mod # go.sum # osmomath/decimal_test.go # osmomath/exp2_test.go # x/gamm/keeper/pool_service.go # x/gamm/pool-models/stableswap/pool_test.go # x/twap/logic.go # x/twap/strategy.go # x/twap/strategy_test.go * Tryfix conflicts * go mod tidy * Update to osmomath v0.0.2 * refactor(osmoutils): use Dec for additive tolerance instead of Int (#3711) * refactor(osmoutils): use Dec for additive tolerance instead of Int * changelog (cherry picked from commit 5ab7ebf) # Conflicts: # CHANGELOG.md # osmomath/binary_search.go # x/gamm/pool-models/balancer/pool_test.go # x/gamm/pool-models/internal/cfmm_common/lp.go # x/gamm/pool-models/stableswap/amm.go # x/gamm/pool-models/stableswap/amm_test.go * tryfix conflict Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Roman <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards: #3540
What is the purpose of the change
Suggesting to change additive tolerance to a Decimal to improve the experience when testing math functions that require high precision.