Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scaling factors to stableswap pool creation #2222

Merged
merged 12 commits into from
Aug 7, 2022
Merged

add scaling factors to stableswap pool creation #2222

merged 12 commits into from
Aug 7, 2022

Conversation

catShaark
Copy link
Contributor

Closes: #2166

What is the purpose of the change

add scaling factors to stableswap pool creation

Brief Changelog

  • add scaling factors to MsgCreateStableswapPool
  • add scaling factors to NewStableswapPool
  • add scaling factors checking in MsgCreateStableswapPool ValidateBasic
  • make changes to existing tests accordingly
  • add new error type : ErrInvalidScalingFactors

Testing and Verifying

This change is already covered by existing tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? no

@catShaark catShaark requested a review from a team July 24, 2022 12:20
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jul 24, 2022
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jul 24, 2022
@catShaark catShaark requested a review from ValarDragon August 3, 2022 10:43
@catShaark
Copy link
Contributor Author

@ValarDragon, I've commited your suggestion, is this ready to merge ?

@ValarDragon
Copy link
Member

Yeah I think so!

When these branches get onto the main osmosis repo, will be so much faster to get merged :)

@ValarDragon
Copy link
Member

We can merge once the test passes, sorry for this crazy number of minor back and forths 😓

@catShaark
Copy link
Contributor Author

We can merge once the test passes, sorry for this crazy number of minor back and forths 😓

Sorry I forgot about the tests, I got them all passed now

@czarcas7ic czarcas7ic merged commit 4798e1b into osmosis-labs:main Aug 7, 2022
@czarcas7ic czarcas7ic mentioned this pull request Aug 19, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
C:docs Improvements or additions to documentation C:x/gamm Changes, features and bugs related to the gamm module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[x/gamm][stableswap]: Add scaling factor to stableswap pool creation
3 participants
@catShaark @ValarDragon @czarcas7ic