Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][stableswap]: Add scaling factor to stableswap pool creation #2166

Closed
Tracked by #1451
catShaark opened this issue Jul 20, 2022 · 2 comments · Fixed by #2222
Closed
Tracked by #1451

[x/gamm][stableswap]: Add scaling factor to stableswap pool creation #2166

catShaark opened this issue Jul 20, 2022 · 2 comments · Fixed by #2222
Assignees
@catShaark

Comments

@catShaark
Copy link
Contributor

catShaark commented Jul 20, 2022 •
edited
Loading

Background

Stable swap pool needs its ScalingFactor set in order to do basic operation like CalcInAmtGivenOut.

Right now, NewStableswapPool doesn't include ScalingFactor in its params so any pools crated from NewStableswapPool will not be usable.

MsgCreateStableswapPool also doesn't include ScalingFactor and doesn't set ScalingFactor to any default value, this means the pool created will also not be usable until a MsgStableSwapAdjustScalingFactors, is this intended ?

Suggested Design

Include ScalingFactor in NewStableswapPool
Include ScalingFactor in MsgCreateStableswapPool
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Jul 20, 2022
@ValarDragon
Copy link
Member

Definitely not intended, this is needed.

@catShaark catShaark self-assigned this Jul 20, 2022
@catShaark catShaark mentioned this issue Jul 24, 2022
Merged
@stackman27
Copy link
Contributor

closely relates to #1470

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Aug 7, 2022
This was referenced Sep 26, 2022
Closed
Closed
@AlpinYukseloglu AlpinYukseloglu changed the title Add scaling factor to stableswap pool creation [x/gamm][stableswap]: Add scaling factor to stableswap pool creation Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@catShaark catShaark

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add scaling factors to stableswap pool creation
3 participants
@ValarDragon @stackman27 @catShaark