You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As per discussion, we should change the test structs to be more aligned with the stableswap pools. Stableswap pools do not have weights but they do have scaling factors.
Therefore, we should remove weights from the tests and instead add scaling factors into the set up
Additionally, we might want to consider using stableswap denoms in tests to be aligned with the abstraction: #1456 (comment)
Acceptance Criteria
Test_StableSwap_CalculateAmountOutAndIn_InverseRelationship testcase struct does not have weights
scaling factors are added and configured correctly instead
denoms are changed to stableswap denoms ("uosmo" -> "ust")
tests continue to pass
The text was updated successfully, but these errors were encountered:
Hi @p0mvn do you think i need #1459 to complete this PR because I believe i need []stableswap.PoolAsset{...} in stableswap_pool.pb.go to test out scaling factors.
Also is there anywhere i can read up on scaling factors? I am a lil confused with how they impact the the stableswap pools.
Description TBD
As per discussion, we should change the test structs to be more aligned with the stableswap pools. Stableswap pools do not have weights but they do have scaling factors.
Therefore, we should remove weights from the tests and instead add scaling factors into the set up
Additionally, we might want to consider using stableswap denoms in tests to be aligned with the abstraction: #1456 (comment)
Acceptance Criteria
Test_StableSwap_CalculateAmountOutAndIn_InverseRelationship
testcase struct does not have weightsThe text was updated successfully, but these errors were encountered: