Enable deterministic Cosmwasm stargate queries #2190
Conversation
sunnya97
changed the title
|
@alexanderbez For twap, we're planning to use bindings. However, we also do want to work towards enabling whitelisted stargate queries, this PR should be good for a round of review! |
This reverts commit eb216a1.
| // StargateQuerier dispatches whitelisted stargate queries | ||
| func StargateQuerier(queryRouter baseapp.GRPCQueryRouter) func(ctx sdk.Context, request *wasmvmtypes.StargateQuery) ([]byte, error) { | ||
| return func(ctx sdk.Context, request *wasmvmtypes.StargateQuery) ([]byte, error) { | ||
| binding, whitelisted := StargateWhitelist.Load(request.Path) |
There was a problem hiding this comment.
Just want to be extra-sure, this path is the /cosmos.auth.v1beta1.Query/Account path, NOT the http path in the proto files right?
There was a problem hiding this comment.
yes, they are defined in the whitelist file
| } | ||
|
|
||
| // normalize response to ensure backward compatibility | ||
| bz, err := NormalizeReponse(binding, res.Value) |
There was a problem hiding this comment.
| bz, err := NormalizeReponse(binding, res.Value) | |
| bz, err := NormalizeResponse(binding, res.Value) |
| @@ -110,6 +144,33 @@ func CustomQuerier(qp *QueryPlugin) func(ctx sdk.Context, request json.RawMessag | |||
| } | |||
| } | |||
|
|
|||
| // NormalizeReponses normalizes the responses by unmarshalling the response then marshalling them again. | |||
| // Normalizing the response is specifically important for responses that contain type of Any. | |||
| func NormalizeReponse(binding interface{}, bz []byte) ([]byte, error) { | |||
There was a problem hiding this comment.
Why is this normalization needed? Since we are not defining custom query protos in our repo and, instead, are directly using what is in the sdk and/or Osmosis, what are we ensuring backward compatibility against?
|
Found out that we need to Json Marshal the responses because cosmwasm stargate querier json unmarshals the responses by default. Closing this PR and opening a new PR replacing this one |
What is the purpose of the change
cref: osmosis-labs/wasmd#7
The original design was to have basic initialization for the whitelisted quries in the wasmd side, but upon leaving the inititialized whitelist empty, this is the attempt to move the whitelisted quries and bindings layer into osmosis side.
Brief Changelog
Testing and Verifying
Further plans to test this is TBD(upon concept ACK of this approach), although I do not have exact plans to test this in a local machine as of rn.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)