Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork cosmwasm to re-enable queries #2098

Closed
1 task
ValarDragon opened this issue Jul 17, 2022 · 3 comments · Fixed by #2353
Closed
1 task

Fork cosmwasm to re-enable queries #2098

ValarDragon opened this issue Jul 17, 2022 · 3 comments · Fixed by #2353
Assignees

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jul 17, 2022

Background

For our next release, I believe that we want to fork wasmd to re-enable stargate queries. We eventually want to move to a whitelist approach, so we can control which queries were making state machine compatability guarantees about. Until they are added back, it must be part of contract review to ensure that all approved contract queries are fine.

To be more precise:

  • A query that is exposed should not have any fields deleted, otherwise it will be state machine breaking
  • When gas tracking is added, it should not be changed within a minor version.

And we should have a beaker test doing this.

As part of this, we should also scope how hard would it be to build a whitelist. (hopefully not much, seeing as we already have a string description of the query type)

Suggested Design

We need to investigate how stargate queries were removed, so that we can add them back.

Acceptance Criteria

  • It is possible to use stargate queries in forked cosmwasm.
@ValarDragon ValarDragon moved this to Needs Review 🔍 in Osmosis Chain Development Jul 17, 2022
@ValarDragon ValarDragon moved this from Needs Review 🔍 to Todo 🕒 in Osmosis Chain Development Jul 17, 2022
@alexanderbez
Copy link
Contributor

The queries should be deterministic too, i.e. no map encoding or anything like that. And if they do, ensure that the output is deterministic.

@ValarDragon ValarDragon moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Aug 4, 2022
@mattverse
Copy link
Member

#2190

@mattverse
Copy link
Member

#2353

@czarcas7ic czarcas7ic moved this from In Progress🏃 to Needs PR Review in Osmosis Chain Development Aug 18, 2022
@czarcas7ic czarcas7ic added this to the V12 Blockers milestone Aug 18, 2022
@czarcas7ic czarcas7ic removed this from the V12 Blockers milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants