-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork cosmwasm to re-enable queries #2098
Comments
The queries should be deterministic too, i.e. no map encoding or anything like that. And if they do, ensure that the output is deterministic. |
czarcas7ic
moved this from In Progress🏃
to Needs PR Review
in Osmosis Chain Development
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
For our next release, I believe that we want to fork wasmd to re-enable stargate queries. We eventually want to move to a whitelist approach, so we can control which queries were making state machine compatability guarantees about. Until they are added back, it must be part of contract review to ensure that all approved contract queries are fine.
To be more precise:
And we should have a beaker test doing this.
As part of this, we should also scope how hard would it be to build a whitelist. (hopefully not much, seeing as we already have a string description of the query type)
Suggested Design
We need to investigate how stargate queries were removed, so that we can add them back.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: