-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query osmo equivilent is staked via superfluid #1632
Merged
hieuvubk
merged 16 commits into
osmosis-labs:main
from
notional-labs:issue-superfluid-osmo
Jun 6, 2022
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fe85343
fix proto
hieuvubk d6bbe3f
get osmo equivilent is staked via superfluid
hieuvubk 7f8a6e0
Merge branch 'osmosis-labs:main' into issue-1525
hieuvubk f56f2bd
Merge pull request #26 from hieuvubk/issue-1525
hieuvubk a30de47
format
hieuvubk 5407105
fix go_fmt
hieuvubk 9aa7a2c
Merge branch 'main' into issue-superfluid-osmo
hieuvubk 7b25e2f
Revert "fix go_fmt"
hieuvubk 70b4906
augment SuperfluidDelegationsByDelegator query
hieuvubk 891ebc4
remove fmt
hieuvubk 6254da7
format
hieuvubk 32edd8e
Merge branch 'osmosis-labs:main' into issue-superfluid-osmo
hieuvubk 5b0a13f
fix spell
hieuvubk 1bbc74d
fix spell, changelog
hieuvubk 260f0c5
query
hieuvubk e900eb4
Merge branch 'main' into issue-superfluid-osmo
hieuvubk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mouthful haha. Any chance we can think of more abbreviated nomenclature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heee we can think of better names. How do u think about the logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand what adding
OSMO
to the query means? I read the original issue and I don't understand why we can't augment the current query (SuperfluidDelegationsByDelegator
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattverse want to create a separate query (as i understant). Refer to #1539 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should change to SuperfluidEquivilentDelegationsByDelegator?