-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1525: sub-section: combine superfluid query and staking query on querying delegation by delegator #1539
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1539 +/- ##
==========================================
- Coverage 19.57% 19.53% -0.05%
==========================================
Files 236 243 +7
Lines 31639 32458 +819
==========================================
+ Hits 6194 6341 +147
- Misses 24310 24958 +648
- Partials 1135 1159 +24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I went through and did a brief review, here's what I think:
SuperfluidDelegationsByDelegator
currently returns all open positions for the superfluid lock: meaning it doesn't return how much osmo equivilent is staked for the user's gamm share, but returns the amount of gamm share itself. That being said, I personally think adding how much osmo equivilent is staked via superfluid to this query would cause confusion if we directly add this to the coins. IMO would be possibly better if we created a new field for this in the struct.
In the same time, I also think creating a separate query for this would be useful as well!
Otherwise, I think the logic itself is LGTM! This is awesome! tysm
#1632 |
Why is this changing every proto |
#1632 |
I think that issue #1525 has a broad scope and should have several prs to fulfill that issue. This pr scope is to combine superfluid query and staking query on querying delegation by delegator. This pr would combine with @hieuvubk idea and code of osmo equivalent in #1632. So, I think that this one is ready for review. |
I have changed it so as to correctly change relevant proto files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments!
Can we also revert changing go.mod and go.sum? Thanks!
Co-authored-by: Matt, Park <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Can you just add a changelog entry?
added, hope I add to correct place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was a big feature! Thanks for this PR!
Closes: #1525
What is the purpose of the change
Combining superfluid query and staking query on querying delegation by delegator
Brief Changelog
the total_equivalent_staked_amount one is idea and code from @hieuvubk
Testing and Verifying
Testing is as following:
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no