Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gov support for superfluid #1555

Merged
merged 1 commit into from
May 21, 2022
Merged

fix: gov support for superfluid #1555

merged 1 commit into from
May 21, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 21, 2022

Closes: #XXX

What is the purpose of the change

@czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: #1543 (comment)

Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers.

We need to e2e test this case in a future PR: #1556

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

Merging #1555 (c37f3ac) into main (f5472e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1555   +/-   ##
=======================================
  Coverage   19.47%   19.47%           
=======================================
  Files         242      242           
  Lines       32258    32258           
=======================================
  Hits         6282     6282           
  Misses      24822    24822           
  Partials     1154     1154           
Impacted Files Coverage Δ
x/superfluid/keeper/keeper.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5472e0...c37f3ac. Read the comment docs.

@p0mvn p0mvn marked this pull request as ready for review May 21, 2022 20:08
@p0mvn p0mvn requested a review from a team May 21, 2022 20:08
@p0mvn p0mvn added the A:backport/v9.x Do not use. backport patches to v9.x branch label May 21, 2022
@mergify mergify bot merged commit 8aaa84b into main May 21, 2022
@mergify mergify bot deleted the roman/gov-sf branch May 21, 2022 20:15
mergify bot pushed a commit that referenced this pull request May 21, 2022
Closes: #XXX

## What is the purpose of the change

@czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: https://github.com/osmosis-labs/osmosis/discussions/1543#discussioncomment-2786650

Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers.

We need to e2e test this case in a future PR: #1556

## Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? not applicable

(cherry picked from commit 8aaa84b)
p0mvn added a commit that referenced this pull request May 21, 2022
Closes: #XXX

## What is the purpose of the change

@czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: https://github.com/osmosis-labs/osmosis/discussions/1543#discussioncomment-2786650

Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers.

We need to e2e test this case in a future PR: #1556

## Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? not applicable

(cherry picked from commit 8aaa84b)

Co-authored-by: Roman <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge A:backport/v9.x Do not use. backport patches to v9.x branch C:x/superfluid
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants