-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: e2e test superfluid gov voting #1556
Comments
mergify bot
pushed a commit
that referenced
this issue
May 21, 2022
Closes: #XXX ## What is the purpose of the change @czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: #1543 (comment) Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers. We need to e2e test this case in a future PR: #1556 ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no - How is the feature or change documented? not applicable
mergify bot
pushed a commit
that referenced
this issue
May 21, 2022
Closes: #XXX ## What is the purpose of the change @czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: https://github.com/osmosis-labs/osmosis/discussions/1543#discussioncomment-2786650 Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers. We need to e2e test this case in a future PR: #1556 ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no - How is the feature or change documented? not applicable (cherry picked from commit 8aaa84b)
p0mvn
added a commit
that referenced
this issue
May 21, 2022
Closes: #XXX ## What is the purpose of the change @czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: https://github.com/osmosis-labs/osmosis/discussions/1543#discussioncomment-2786650 Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers. We need to e2e test this case in a future PR: #1556 ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no - How is the feature or change documented? not applicable (cherry picked from commit 8aaa84b) Co-authored-by: Roman <[email protected]>
Closed via #1586 |
Repository owner
moved this from Todo 🕒
to Done ✅
in Osmosis Chain Development
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
We should convert this manual test case to an e2e test: #1543 (comment)
Suggested Design
Acceptance Criteria
The text was updated successfully, but these errors were encountered: