-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 support to Docker images #1541
Conversation
Should I target |
The same logic here could be used to create a "releaser" docker image that creates the binaries for both |
Codecov Report
@@ Coverage Diff @@
## main #1541 +/- ##
=======================================
Coverage 19.46% 19.46%
=======================================
Files 242 242
Lines 32255 32255
=======================================
Hits 6279 6279
Misses 24822 24822
Partials 1154 1154 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Targetting main is fine, we can backport the change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikever could you also update the following image please:
https://github.com/osmosis-labs/osmosis/blob/82e58f8f5f7e200e6659de6490526391811dd9ea/contrib/images/rbuilder/Dockerfile
It is needed for building the release binaries
Since now we support different architectures, and each one would have to be linked against its corresponding CosmWasm library, what do you think about using It's pretty cool and automation-friendly: https://goreleaser.com/quick-start/ If you want to give it a shot, I think it's best to track this releasing part in another issue. lmk! |
Yeah I'm all for looking into that later. We still need to make the current release image consistent with the main one so that we can make releases for all supported platforms. We can either do it here or in a separate issue |
I'm tracking the release part in another issue: #1550 because it's quite tricky and it deserves its own PR to discuss the solution. I have already started doing some work in this branch: https://github.com/osmosis-labs/osmosis/compare/main...nikever:feat/add-go-releaser?expand=1 We can merge this one since the Docker part should be okay. |
Closes: #XXX
What is the purpose of the change
This PR extends the work done in #1535 to introduce support for
arm64
architecture making osmosis docker image multi-architecture (amd64
andarm64
).I have also updated the CI to build and push the image for multiple architectures.
Please note that it takes ~20 minutes for the build complete but it would run only on every new tag so I think it's acceptable.
Brief Changelog
arm64
supportarm64
Testing and Verifying
You can build for arm64 with:
docker buildx build --platform linux/arm64 --tag osmosis:arm64 .
I tested the CI in my fork: https://github.com/nikever/osmosis/runs/6505857265?check_suite_focus=true
Documentation and Release Note
arm64
support!)Unreleased
section inCHANGELOG.md
? yes