Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade wasmd to v0.27.0.rc3-osmo and ibc-go to v3 (#1527) #1535

Merged
merged 5 commits into from
May 18, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 18, 2022

Closes: #XXX

What is the purpose of the change

Context: #1527

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@ValarDragon
Copy link
Member

ah rip we merged that PR to the wrong branch :(

Need to revert that v8.x commit as well

@p0mvn
Copy link
Member Author

p0mvn commented May 18, 2022

@ValarDragon Should we make a v9.x branch at this point?

@ValarDragon
Copy link
Member

yeah, I think we should make a v9 branch after this gets merged to main

@p0mvn p0mvn changed the title chore: upgrade wasmd to v0.27.0.rc3-osmo and ibc-go to v3 (backport #1527) chore: upgrade wasmd to v0.27.0.rc3-osmo and ibc-go to v3 (#1527) May 18, 2022
@p0mvn p0mvn marked this pull request as ready for review May 18, 2022 16:24
@p0mvn p0mvn requested a review from a team May 18, 2022 16:24
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1535 (4b5ccfc) into main (b444708) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1535   +/-   ##
=======================================
  Coverage   19.66%   19.66%           
=======================================
  Files         241      241           
  Lines       31837    31837           
=======================================
  Hits         6261     6261           
  Misses      24424    24424           
  Partials     1152     1152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b444708...4b5ccfc. Read the comment docs.

@mergify mergify bot merged commit 7bff4c9 into main May 18, 2022
@mergify mergify bot deleted the roman/backport-wasmd-upgrade branch May 18, 2022 19:30
mergify bot pushed a commit that referenced this pull request May 20, 2022
Closes: #XXX

## What is the purpose of the change

This PR extends the work done in #1535 to introduce support for `arm64` architecture making osmosis docker image multi-architecture (`amd64` and `arm64`).

I have also updated the CI to build and push the image for multiple architectures.

Please note that it takes ~20 minutes for the build complete but it would run only on every new tag so I think it's acceptable.

## Brief Changelog

- Modify Dockerfile to add `arm64` support
- Update docker CI to build and push for `arm64`

## Testing and Verifying

You can build for arm64 with:

```bash
docker buildx build --platform linux/arm64 --tag osmosis:arm64 .
```

I tested the CI in my fork: https://github.com/nikever/osmosis/runs/6505857265?check_suite_focus=true

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? yes (`arm64` support!)
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes
  - How is the feature or change documented? not applicable
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants