refactor: add PokeTokenWeights to Pool interface #1232
Conversation
alexanderbez
added
the
C:x/gamm
| // | ||
| // 3. t > start_time + duration: w(t) = target_pool_weights | ||
| switch { | ||
| case blockTime.Before(params.StartTime) || params.StartTime.Equal(blockTime): |
There was a problem hiding this comment.
reviewer: no logical changes, just switched the existing branching code to be switch-based instead of if/elses.
There was a problem hiding this comment.
should we generally aim to prefer the code base to be switch based instead of if/elses?
There was a problem hiding this comment.
Yeah, definitely. A single if/else is fine and OK. Once you have an if/if else/.../else block, then it becomes hard to read and a switch is much cleaner.
|
@ValarDragon we actually don't have any keeper-based tests for this, so even with this change, we wouldn't catch anything I think? Also, more I think about it, idk how I feel about a |
|
Agreed with the concern over |
| // | ||
| // 3. t > start_time + duration: w(t) = target_pool_weights | ||
| switch { | ||
| case blockTime.Before(params.StartTime) || params.StartTime.Equal(blockTime): |
There was a problem hiding this comment.
should we generally aim to prefer the code base to be switch based instead of if/elses?
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
+ Coverage 20.96% 20.98% +0.01%
==========================================
Files 196 196
Lines 25337 25340 +3
==========================================
+ Hits 5312 5317 +5
+ Misses 19066 19065 -1
+ Partials 959 958 -1
Continue to review full report at Codecov.
|
| @@ -359,7 +359,7 @@ func TestBalancerPoolPokeTokenWeights(t *testing.T) { | |||
| defaultStartTime := time.Unix(1618703511, 0) | |||
| defaultStartTimeUnix := defaultStartTime.Unix() | |||
| defaultDuration := 100 * time.Second | |||
| floatGuaranteedPrecison := float64(GuaranteedWeightPrecision) | |||
| floatGuaranteedPrecision := float64(GuaranteedWeightPrecision) | |||
Closes: #1213
Description
PokePoolto thePoolinterfaceGetPool->GetPoolAndPokeGetPools->GetPoolsAndPokeFor contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer