Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x/gamm] Add PokePool function to AMM interface #1213

Closed
Tracked by #1450
ValarDragon opened this issue Apr 6, 2022 · 2 comments · Fixed by #1232
Closed
Tracked by #1450

[x/gamm] Add PokePool function to AMM interface #1213

ValarDragon opened this issue Apr 6, 2022 · 2 comments · Fixed by #1232
Assignees
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:task ⚙️ A task belongs to a story

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Apr 6, 2022

Copied from a slack discussion:

I have a feeling the AMM refactor broke LBP's, by not calling PokeTokenPoolWeights on GetPool . Our tests didn't catch this, because at the moment they call Poke directly, whereas they should call it from GetPool on the keeper method

Theres two ways that come to my mind for how to fix this:

  • Add pool.PokeTokenWeights at the beginning of every pool interface function in balancer.go
  • Add a PokePool function in the pool interface, that then gets called in keeper.GetPool()

I like the second approach better, what do others think? The first seems more brittle,

@mconcat : PokePool is equivalent with getting the newest version of the pool, so second makes more sense

@alexanderbez : I like the 2nd option too

@ValarDragon ValarDragon moved this to 🔍 Needs Review in Osmosis Chain Development Apr 6, 2022
@ValarDragon ValarDragon moved this from 🔍 Needs Review to 🕒 Todo in Osmosis Chain Development Apr 6, 2022
@alexanderbez
Copy link
Contributor

@ValarDragon can I pick this up?

@ValarDragon
Copy link
Member Author

Sure!

@ValarDragon ValarDragon added C:x/gamm Changes, features and bugs related to the gamm module. T:task ⚙️ A task belongs to a story labels Apr 7, 2022
@ValarDragon ValarDragon mentioned this issue Apr 7, 2022
6 tasks
Repository owner moved this from 🕒 Todo to ✅ Done in Osmosis Chain Development Apr 12, 2022
@p0mvn p0mvn changed the title Add PokePool function to AMM interface [x/gamm] Add PokePool function to AMM interface May 9, 2022
@p0mvn p0mvn mentioned this issue May 9, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:task ⚙️ A task belongs to a story
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants