Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for org.apache.curator:curator-framework:5.5.0 #383

Closed
wants to merge 1 commit into from
Closed

Add support for org.apache.curator:curator-framework:5.5.0 #383

wants to merge 1 commit into from

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented Sep 6, 2023 •
edited
Loading

What does this PR do?

Code sections where the PR accesses files, network, docker or some external service

  • (example link to code section)
  • Null.

Checklist before merging

@linghengqian linghengqian mentioned this pull request Sep 6, 2023
Closed
7 tasks
@linghengqian linghengqian marked this pull request as ready for review September 6, 2023 16:55
@linghengqian linghengqian requested a review from a team as a code owner September 6, 2023 16:55
@linghengqian linghengqian requested a review from msupic September 6, 2023 16:55
@linghengqian linghengqian mentioned this pull request Sep 7, 2023
Closed
2 tasks
@linghengqian linghengqian force-pushed the new-apache-curator-framework branch from 5952616 to cd0211b Compare September 11, 2023 16:08
This was referenced Sep 13, 2023
Closed
Closed
msupic
msupic requested changes Sep 21, 2023
View reviewed changes
...framework/5.5.0/src/test/java/org_apache_curator/curator_framework/CuratorFrameworkTest.java
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertThrows;

public class CuratorFrameworkTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test can be executed in a native image without any metadata defined in the metadata/org.apache.curator/curator-framework/5.5.0/reflect-config.json file. It requires only zookeeper metadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The handling of the shaded package involves some classes that are not easily verified in unit tests, and it will take me some time to verify the remaining two classes.

  • Normally Guava does not require additional GraalVM Reachability Metadata, but I remember I observed a failed nativeTest on GraalVM 22.3.1 and I needed to re-validate on GraalVM 23.1.0.

  • Additionally, for existing arbitrary test submodules, the GRM central repository's git is now unable to run nativeTest on GraalVM CE 23.1.0 For JDK21.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata/org.apache.curator/curator-framework/5.5.0/reflect-config.json Show resolved Hide resolved
@linghengqian linghengqian force-pushed the new-apache-curator-framework branch from cd0211b to dfe4127 Compare September 21, 2023 17:15
@linghengqian linghengqian deleted the new-apache-curator-framework branch September 23, 2023 07:12
@linghengqian linghengqian mentioned this pull request Sep 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msupic msupic msupic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for org.apache.curator:curator-*:5.4.0
2 participants
@linghengqian @msupic