Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize numbers, units in scale, info panels #4672

Merged
merged 7 commits into from
Jan 23, 2018
Merged

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Jan 9, 2018

Numbers and units appear unlocalized throughout iD. This PR begins to localize some of them. Here are some before-and-afters:

scale before scale after
Scale bar:

  • Depending on the browser language, a period will group the thousands digits and a comma will serve as the decimal separator.
  • In Chinese, the unit symbol would be translated as 公里.

search coordinate before search coordinate after
Coordinate in search results:

  • Coordinates appear in the familiar degree-minute-second format to clarify that latitudes are displayed before longitudes.

measurement area metric before measurement area metric after
Measurement panel, seen here in metric with a closed area selected:

  • “Closed” will appear after “area” or “line” in some locales.
  • The English localization abbreviates square feet and square miles as “sq ft” and “sq mi”, respectively, instead of “ft²” and “mi²”.
  • Lengths and areas are rounded to four significant figures instead of a fixed decimal place.

location before location after
Location panel:

  • Coordinates appear in both degree-minute-second and decimal format, for better precision and easier copy-pasting.

measurement area persian 
Measurement panel partially localized into Persian

Fixes #3597.

1ec5 added 7 commits January 9, 2018 00:10
In many languages, the word for “closed” would follow the word for “line” or “area”, not precede it. Additionally, the word for “closed” may differ depending on what it modifies.
@1ec5 1ec5 added the localization Adapting iD across languages, regions, and cultures label Jan 9, 2018
@1ec5 1ec5 self-assigned this Jan 9, 2018
@1ec5 1ec5 requested a review from bhousel January 9, 2018 12:12
@bhousel
Copy link
Member

bhousel commented Jan 23, 2018

I played around with this today and it looks great - sorry it took me a few weeks to get to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbers and units in measurement box are unlocalized
2 participants