Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not localize coordinate in info panel #4765

Closed
HolgerJeromin opened this issue Feb 2, 2018 · 5 comments
Closed

Do not localize coordinate in info panel #4765

HolgerJeromin opened this issue Feb 2, 2018 · 5 comments
Labels
localization Adapting iD across languages, regions, and cultures

Comments

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Feb 2, 2018

IMO the whole use of the structured coordinate in the info pane is to reuse in search or wikipedia.

But the German number format "51,8852685, 8,478078" is not parsable with its three comma.
ref #4672

@manfredbrandl
Copy link
Contributor

Parsing the info panel might not be optimal, maybe there is a better alternative. What is the use case?

@bhousel
Copy link
Member

bhousel commented Feb 2, 2018

Ah this makes sense that people expect the coordinates to be copy-pastable into other systems.
@1ec5 does this sound ok?

@bhousel bhousel added the localization Adapting iD across languages, regions, and cultures label Feb 2, 2018
@manfredbrandl
Copy link
Contributor

I see. What if we omit the comma between latitude and longitude?

@1ec5
Copy link
Collaborator

1ec5 commented Feb 3, 2018

I always thought of the panel as being populated with human-readable text as opposed to machine-readable text. I’ve used some software (particularly on the Mac) that expects localized number input even for coordinates, but it’s true that this behavior is rare on the Web.

I’m not really opposed to unlocalizing this particular label, since the degree-minute-second label is still localized. On the other hand, if we figure out how to allow localized coordinates as input in the search bar, would it be confusing if this panel used unlocalized numbers?

@bhousel bhousel closed this as completed in 668c17a Mar 2, 2018
@bhousel
Copy link
Member

bhousel commented Mar 2, 2018

Ok I ended up unlocalizing the decimalCoordinatePair function.
I don't think anybody would be likely to be confused by the output, which is my main concern.

We can revisit later if people want to.
(For example, removing the comma from the German translation on Transifex would also be an equally ok solution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

No branches or pull requests

4 participants