Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localized field hidden despite nonempty subkeys #10333

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix localized field hidden despite nonempty subkeys #10333

merged 2 commits into from
Jul 16, 2024

Conversation

samhoooo
Copy link

Fix #10323

  • Add logic to show a field of type localized that has any key beginning with the field’s key and a colon
  • Use the same regular expression added in Add multilingual field exceptions #9124 to test whether the field would show the subkey
Screen.Recording.2024-07-16.at.12.49.12.mov

@tyrasd tyrasd added bug A bug - let's fix this! localization Adapting iD across languages, regions, and cultures field An issue with a field in the user interface labels Jul 16, 2024
tyrasd
tyrasd approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this fix looks good to me 👍

@tyrasd tyrasd merged commit da9aebb into openstreetmap:develop Jul 16, 2024
3 checks passed
bhousel added a commit to facebook/Rapid that referenced this pull request Jul 18, 2024
@bhousel
Show 'localized' field if it matches a language subtag e.g. name:eo
a0cf4b2 
re: #1494
re: openstreetmap/iD#10333
re: openstreetmap/iD#10323
@bhousel bhousel mentioned this pull request Jul 18, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

Assignees
No one assigned
Labels
bug A bug - let's fix this! field An issue with a field in the user interface localization Adapting iD across languages, regions, and cultures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localized field hidden despite nonempty subkeys
2 participants
@samhoooo @tyrasd