Localized field hidden despite nonempty subkeys

[1ec5]

The Name field is a localized field that displays not only name=* but also a very large number of potential name:xyz=* subkeys. The Name field is universal, so it’s enabled for every preset. However, some presets don’t display it by default. For these presets, the field stays hidden even if the feature has name:xyz=* set.

Steps to reproduce

To reproduce this issue, create a Windpump (man_made=windpump) and manually tag it with name:es=El Gran Molino. Observe that the Name field doesn’t appear.

Impact

In general, it’s incorrect to set name:xyz=* without setting name=*. However, this is a subject of debate for some very international features, such as oceans and seas. Even if it’s a tagging error, the field should automatically show because it isn’t empty. This will be a bigger problem for the name fields being added in openstreetmap/id-tagging-schema#215. Those fields are universal but aren’t included by default in any preset, because the local language isn’t guaranteed to need them all, even as some other language may need one of them.

Diagnosis

The logic for showing a field needs a special case for fields of type localized that tests for any key beginning with the field’s key and a colon:

iD/modules/ui/field.js

Lines 90 to 102 in aaa1441

	function tagsContainFieldKey() {
	return allKeys().some(function(key) {
	if (field.type === 'multiCombo') {
	for (var tagKey in _tags) {
	if (tagKey.indexOf(key) === 0) {
	return true;
	}
	}
	return false;
	}
	return _tags[key] !== undefined;
	});
	}

We should use the same regular expression added in #9124 to test whether the field would show the subkey:

iD/modules/ui/fields/localized.js

Lines 127 to 131 in aaa1441

	// matches for field:<code>, where <code> is a BCP 47 locale code
	// motivation is to avoid matching on similarly formatted tags that are
	// not for languages, e.g. name:left, name:source, etc.
	var m = k.match(/^(.*):([a-z]{2,3}(?:-[A-Z][a-z]{3})?(?:-[A-Z]{2})?)$/);
	if (m && m[1] === field.key && m[2]) {

[samhoooo]

Hi @1ec5, I created a fix for the above issue.

This is my first time to contribute here, so would be really appreciate if you could give some comments. Thank you!