Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance UpgradeDependencyVersionTest #4788

Merged
merged 3 commits into from
Dec 17, 2024
Merged

enhance UpgradeDependencyVersionTest #4788

merged 3 commits into from
Dec 17, 2024
+158 −102

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Dec 16, 2024 •
edited
Loading

What's changed?

UpgradeDependencyVersionTest.java

What's your motivation?

validate the upgrade of a Gradle testImplementation library

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@sullis sullis force-pushed the UpgradeDependencyVersionTest-mockito branch from b4a8946 to 80ff146 Compare December 16, 2024 04:28
@timtebeek timtebeek mentioned this pull request Dec 16, 2024
Closed
3 tasks
@timtebeek timtebeek self-requested a review December 16, 2024 11:23
@timtebeek timtebeek added the test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail label Dec 16, 2024
@sullis sullis force-pushed the UpgradeDependencyVersionTest-mockito branch from 80ff146 to bf553e6 Compare December 17, 2024 20:04
@sullis
Copy link
Contributor Author

sullis commented Dec 17, 2024

I changed Mockito "4.x" to "4.11.0" -- this test is no longer impacted by future versions of Mockito 4.x

timtebeek
timtebeek approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sullis ! I've pushed up another small change to make the tests more expressive when they fail, and with that I think we're good to merge.

@timtebeek timtebeek merged commit 372246c into openrewrite:main Dec 17, 2024
2 checks passed
@sullis
Copy link
Contributor Author

sullis commented Dec 17, 2024

related PR: openrewrite/rewrite-testing-frameworks#651

@sullis sullis deleted the UpgradeDependencyVersionTest-mockito branch December 17, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@sullis sullis

Labels
test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail
Projects
OpenRewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sullis @timtebeek