validate mockito library upgrade #131
Closed
+60
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sullis
changed the title
sullis
force-pushed
the
upgradeMockitoInGradleProject
branch
from
ea333b7 to
57f60b8
Compare
timtebeek
reviewed
Dec 16, 2024
| } | ||
|
|
||
| dependencies { | ||
| testImplementation("org.mockito:mockito-junit-jupiter:4.11.0") |
There was a problem hiding this comment.
Has mockito completely stopped putting out 4.x releases? I'd think so given that 4.11 stems from December 2022, but figured to check since we wouldn't want to update the test output if there's a newer release.
|
Thanks for helping ensure downstream recipes see the correct updated Gradle project marker. Since the recipe here merely delegates I'd lean towards only merging the test you added in Would you be ok with that change? Or did you (fore)see a potential failure mode when we don't? |
|
Let's continue with the tests in openrewrite/rewrite only for now; thanks for looking out for the not-visible change here as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
new unit test for UpgradeDependencyVersion
What's your motivation?
I wanted to verify Mockito dependency upgrades.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist