NO-JIRA: chore(nbcs): update tooling in controller's Makefiles #391
Conversation
|
@jiridanek: once the present PR merges, I will cherry-pick it on top of stable in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jiridanek: once the present PR merges, I will cherry-pick it on top of v1.9-branch in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jiridanek
changed the title
|
/hold Hey Jiri, could you switch the target branch to main please? |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jiridanek
force-pushed
the
update_tooling_odh-controlelr
branch
2 times, most recently
from
601d07b to
1546f4c
Compare
jiridanek
added
ok-to-test
and removed
do-not-merge/hold
|
Sure, rebased, retargetted. |
jiridanek
force-pushed
the
update_tooling_odh-controlelr
branch
from
1546f4c to
e0b6185
Compare
make generate GOBIN=/Users/jdanek/IdeaProjects/kubeflow/components/odh-notebook-controller/bin go install sigs.k8s.io/controller-tools/cmd/[email protected] /Users/jdanek/IdeaProjects/kubeflow/components/odh-notebook-controller/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..." panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1008a00a4] ```
…ntroller previously
jiridanek
force-pushed
the
update_tooling_odh-controlelr
branch
from
e0b6185 to
3532395
Compare
|
New changes are detected. LGTM label has been removed. |
|
rebased |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a followup of opendatahub-io#391 (1b2dd4f). Without this, we can see the following failure during the e2e tests execution: ``` make run-ci-e2e-tests ... GOBIN=/home/jstourac/workspace/rhosai/odh/kubeflow/components/odh-notebook-controller/bin go install sigs.k8s.io/kustomize/v3/cmd/[email protected] go: sigs.k8s.io/kustomize/v3/cmd/[email protected]: sigs.k8s.io/kustomize/v3/cmd/[email protected]: invalid version: unknown revision v3/cmd/kustomize/v5.0.2 make[1]: *** [Makefile:243: kustomize] Error 1 ... ``` This caused that all e2e tests failed. After this fix, some e2e tests pass. The other seem to fail on a problem unrelated to this one.
This is a followup of opendatahub-io#391 (1b2dd4f). Without this, we can see the following failure during the e2e tests execution: ``` make run-ci-e2e-tests ... GOBIN=/home/jstourac/workspace/rhosai/odh/kubeflow/components/odh-notebook-controller/bin go install sigs.k8s.io/kustomize/v3/cmd/[email protected] go: sigs.k8s.io/kustomize/v3/cmd/[email protected]: sigs.k8s.io/kustomize/v3/cmd/[email protected]: invalid version: unknown revision v3/cmd/kustomize/v5.0.2 make[1]: *** [Makefile:243: kustomize] Error 1 ... ``` This caused that all e2e tests failed. After this fix, some e2e tests pass. The other seem to fail on a problem unrelated to this one.
Look at this first, after this gets in, the diff will shrink
make generateincomponents/notebook-controllerto update the yamls #392Description
Update tooling in notebook controller Makefile,
This is motivated by first the fact that old controller-gen segfaults on my machine, and that old setup-envtest does not run on macOS. Kustomize is updated to align with https://issues.redhat.com/browse/RHOAIENG-11679 and
How Has This Been Tested?
make test,make manifests,make generatelocallyMerge criteria: