Skip to content

Commit

Permalink
apply the same changes for notebook-controller as for odh-notebook-co…
Browse files Browse the repository at this point in the history
…ntroller previously
  • Loading branch information
jiridanek committed Oct 2, 2024
1 parent ea1d95f commit e0b6185
Show file tree
Hide file tree
Showing 6 changed files with 185 additions and 22 deletions.
8 changes: 4 additions & 4 deletions components/notebook-controller/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -143,18 +143,18 @@ $(LOCALBIN): ## Ensure that the directory exists
CONTROLLER_GEN = $(LOCALBIN)/controller-gen
.PHONY: controller-gen
controller-gen: ## Download controller-gen locally if necessary.
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.8.0
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.3

KUSTOMIZE = $(shell pwd)/bin/kustomize
.PHONY: kustomize
kustomize: ## Download kustomize locally if necessary.
$(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/v3/cmd/kustomize@v3.2.0)
$(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2)

ENVTEST = $(shell pwd)/bin/setup-envtest
ENVTEST_VERSION?=release-0.14
ENVTEST_VERSION?=v0.0.0-20240923090159-236e448db12c

.PHONY: envtest
envtest: ## Download envtest-setup locally if necessary.
envtest: ## Download setup-envtest locally if necessary.
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_VERSION))

# go-get-tool will 'go get' any package $2 and install it to $1.
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e0b6185

Please sign in to comment.