Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Imports for Class Converter Factory #19057

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Correct Imports for Class Converter Factory #19057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rvice/src/main/java/org/openmetadata/service/secrets/converter/ClassConverterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@

package org.openmetadata.service.secrets.converter;

import com.mysql.cj.MysqlConnection;
import java.util.Map;
import lombok.Getter;
import org.flywaydb.core.internal.database.redshift.RedshiftConnection;
import org.openmetadata.schema.auth.SSOAuthMechanism;
import org.openmetadata.schema.entity.automations.TestServiceConnectionRequest;
import org.openmetadata.schema.entity.automations.Workflow;
Expand All @@ -34,7 +32,9 @@
import org.openmetadata.schema.services.connections.database.GreenplumConnection;
import org.openmetadata.schema.services.connections.database.HiveConnection;
import org.openmetadata.schema.services.connections.database.IcebergConnection;
import org.openmetadata.schema.services.connections.database.MysqlConnection;
import org.openmetadata.schema.services.connections.database.PostgresConnection;
import org.openmetadata.schema.services.connections.database.RedshiftConnection;
import org.openmetadata.schema.services.connections.database.SalesforceConnection;
import org.openmetadata.schema.services.connections.database.SapHanaConnection;
import org.openmetadata.schema.services.connections.database.TrinoConnection;
Expand Down
1 change: 1 addition & 0 deletions .../src/main/resources/json/schema/entity/services/connections/database/mysqlConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"authType": {
"title": "Auth Configuration Type",
"description": "Choose Auth Config Type.",
"mask": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the mask at this level?

Copy link
Contributor Author

@mohityadav766 mohityadav766 Dec 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works without mask as well, i was checking at other connection jsons we are adding it similarly
if doesn't make much sense we can remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmbrull lmk wdyt

"oneOf": [
{
"$ref": "./common/basicAuth.json"
Expand Down
1 change: 1 addition & 0 deletions ...c/main/resources/json/schema/entity/services/connections/database/postgresConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"authType": {
"title": "Auth Configuration Type",
"description": "Choose Auth Config Type.",
"mask": true,
"oneOf": [
{
"$ref": "./common/basicAuth.json"
Expand Down
4 changes: 1 addition & 3 deletions ...c/main/resources/ui/src/generated/entity/services/connections/database/mysqlConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/


/**
/**
* Mysql Database Connection Config
*/
export interface MysqlConnection {
Expand Down
4 changes: 1 addition & 3 deletions ...ain/resources/ui/src/generated/entity/services/connections/database/postgresConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/


/**
/**
* Postgres Database Connection Config
*/
export interface PostgresConnection {
Expand Down
Loading