Correct Imports for Class Converter Factory #19057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohityadav766
requested review from
a team,
ShaileshParmar11,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
github-actions
bot
added
backend
safe to test
Jest test CoverageUI tests summary
|
|
pmbrull
reviewed
Dec 14, 2024
| @@ -44,6 +44,7 @@ | |||
| "authType": { | |||
| "title": "Auth Configuration Type", | |||
| "description": "Choose Auth Config Type.", | |||
| "mask": true, | |||
There was a problem hiding this comment.
do we need the mask at this level?
There was a problem hiding this comment.
it works without mask as well, i was checking at other connection jsons we are adding it similarly
if doesn't make much sense we can remove it
There was a problem hiding this comment.
@pmbrull lmk wdyt
harshach
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fix Import for Mysql and Redshift Connection
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>